$(this).data("id") // will return the number 123
const dataId = $('#elementId').attr("data-id");
To get the contents of the attribute data-id (like in <a data-id="123">link</a>) ///you have to use
$(this).attr("data-id") // will return the string "123"
//or .data() (if you use newer jQuery >= 1.4.3)
$(this).data("id") // will return the number 123